Create common cmake modules for dependency resolution [ESD-1245] #2
Conversation
woodfell
force-pushed
the
woodfell/create_standard_find_modules
branch
from
b9210fb to
ecc36bd
Compare
woodfell
force-pushed
the
woodfell/create_standard_find_modules
branch
from
207a416 to
d669f1e
Compare
woodfell
force-pushed
the
woodfell/create_standard_find_modules
branch
from
33a6151 to
1fcb326
Compare
woodfell
force-pushed
the
woodfell/create_standard_find_modules
branch
from
f12cfd8 to
ab73780
Compare
|
@benjaminaltieri @jbangelo @martin-swift I have updated all the other PRs to use these modules and removed all the temporary hack targets. The only project which doesn't use the generic tidy/format targets is starling. It still uses this module but it has custom scripts in the repo. Starling is probably worth revisiting though, the script uses some hard coded flags to clang-tidy which passes, but as soon as it is run against the compile command database exported from cmake it throws loads of errors. |
|
Should default SN |
@jbangelo @martin-swift |
let's let individual repos decide what linting they use. it's important that the module supports pulling this in (possibly a custom script as well? i.e. not only |
benjaminaltieri
left a comment
benjaminaltieri
left a comment
There was a problem hiding this comment.
IGTM, would like a couple small tweaks if you approve or happy to hear other ideas
There was a problem hiding this comment.
looks good, for any CI that fails to create the clang targets we can just set I'll revise that idea, I'm fine to go back to the previous behavior of not defining a clang target if we can't find the toolENABLE_CLANG_TIDY and ENABLE_CLANG_FORMAT to OFF in the travis.yml or travis.sh
woodfell
force-pushed
the
woodfell/create_standard_find_modules
branch
from
3dd6a7c to
3c390e5
Compare
This PR implements some common cmake functions used for the dependency resolution and provides standard Find* modules for common packages.
The two main new modules are:
GenericFindDependency
A function to search for a dependency. Searches in either bundled source code or system libraries. Configurable through either function parameters or global variables defined on the command line or elsewhere at configure time. Don't call directly, call from a Find* style cmake module.
SwiftCmakeOptions
Sets up and configures several generic options to enable or disable package features such as unit tests, documentation, or example code.
GenericFindDependency.cmake and SwiftCmakeOptions.cmake contain header with documentation of parameters and usage. The PR also includes several Find* modules for commonly used packages including all swift repositories. See other repos for examples of SwiftCmakeOptions.
As part of this work the new modules are being imported to other swift repositories.
Related PRs:
libsbp - swift-nav/libsbp#692
librtcm - https://github.com/swift-nav/librtcm/pull/85
libswiftnav - https://github.com/swift-nav/libswiftnav/pull/85
gnss-converters https://github.com/swift-nav/gnss-converters/pull/193
libsettings - swift-nav/libsettings#37
starling - https://github.com/swift-nav/starling/pull/2273
albatross - swift-nav/albatross#126
orion_proto - https://github.com/swift-nav/orion_proto/pull/31
orion-engine - https://github.com/swift-nav/orion-engine/pull/120
orion - https://github.com/swift-nav/orion/pull/400